Skip site navigation (1)Skip section navigation (2)

ports/107217: [PATCH] multimedia/mplayer: fix h264/polyaudio bug

From:Sergio Lenzi <lenzi@k1.com.br>
Date:Tue, 26 Dec 2006 19:50:23 -0200 (BRST)
Subject:[PATCH] multimedia/mplayer: [SUMMARIZE CHANGES]
Send-pr version:3.113

Number:107217
Category:ports
Synopsis:[PATCH] multimedia/mplayer: fix h264/polyaudio bug
Severity:non-critical
Priority:low
Responsible:itetcu@FreeBSD.org
State:closed
Class:sw-bug
Arrival-Date:Tue Dec 26 22:10:17 GMT 2006
Closed-Date:Mon Jan 08 16:02:32 GMT 2007
Last-Modified:Mon Jan 8 16:10:15 GMT 2007
Originator:Sergio Lenzi
Release:FreeBSD 6.1-RELEASE i386

Organization:
k1 sistemas
 
Environment:
System: FreeBSD k1.com.br 6.1-RELEASE FreeBSD 6.1-RELEASE #1: Sat Nov 4 17:26:48 BRST
 
Description:
[DESCRIBE CHANGES]
when building mplayer with h264 and polyaudio, an external
reference is generated to: last_coeff_flag_offset in the polyaudio
module, that is static in the h264.
a patch is done to remove the static atribute...

Added file(s):
- files/patch-h264

Port maintainer (riggs@rrr.de) is cc'd.

Generated with FreeBSD Port Tools 0.77
 
How-To-Repeat:
build the package (mplayer) with all the options turned on (h264 & polyaudio)
 
Fix:
Download mplayer-0.99.10_1.patch
diff -ruN --exclude=CVS /usr/ports/multimedia/mplayer/files/patch-h264 /fileserver/ports/multimedia/mplayer/files/patch-h264
--- /usr/ports/multimedia/mplayer/files/patch-h264       Wed Dec 31 21:00:00 1969
+++ /fileserver/ports/multimedia/mplayer/files/patch-h264        Thu Dec 21 15:02:08 2006
@@ -0,0 +1,11 @@
+--- libavcodec/h264.c.orig      Thu Dec 21 14:57:54 2006
++++ libavcodec/h264.c   Thu Dec 21 15:00:14 2006
+@@ -6034,7 +6034,7 @@
+     return ctx + 4 * cat;
+ }
+
+-static const __attribute((used)) uint8_t last_coeff_flag_offset_8x8[63] = {
++const __attribute((used)) uint8_t last_coeff_flag_offset_8x8[63] = {
+     0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
+     2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
+     3, 3, 3, 3, 3, 3, 3, 3, 4, 4, 4, 4, 4, 4, 4, 4,


Release-Note:
 
Audit-Trail:
State Changed
From-To:open->feedback
By:edwin
When:Tue Dec 26 22:10:30 UTC 2006
Why:Awaiting maintainers feedback

Responsible Changed
From-To:freebsd-ports-bugs->itetcu
By:itetcu
When:Sat Dec 30 03:35:13 UTC 2006
Why:adjust synopsis, Severity, Priority and take.

Reply via E-mail
From:"Thomas E. Zander" <riggs@rrr.de>
Date:Thu, 4 Jan 2007 22:38:02 +0100
Thanks for the patch!

Looks alright at first sight, but I have two additional issues pending
and I'd like to commit them altogether. I'll send the patches as soon
as I am back at my desk (and box) next week.

TIA,
Riggs

State Changed
From-To:feedback->open
By:itetcu
When:Thu Jan 4 21:54:14 UTC 2007
Why:maintainer approved, but wait for 2 more patches from him

Reply via E-mail
From:"Thomas E. Zander" <riggs@rrr.de>
Date:Sun, 7 Jan 2007 23:38:54 +0100


Okay, the patch to the port is attached. It comprises:

o Original patch for h264-polyaudio by Sergio
(new file: files/patch-libavcodec-h264.c)
o A security fix provided by the mplayer development team for a
possible remote buffer overflow in rtsp streams
o Correct library dependence and OPTIONS for samba support

Thx,
Riggs



Download patch-2.diff
diff -ruN /usr/ports/multimedia/mplayer/Makefile mplayer/Makefile
--- /usr/ports/multimedia/mplayer/Makefile       Mon Jan  1 23:13:01 2007
+++ mplayer/Makefile     Sun Jan  7 22:07:00 2007
@@ -84,7 +84,7 @@
 
 PORTNAME=       mplayer
 PORTVERSION=    0.99.10
-PORTREVISION=   1
+PORTREVISION=   2
 CATEGORIES=     multimedia audio
 MASTER_SITES=   http://www1.mplayerhq.hu/MPlayer/releases/ \
                 http://www2.mplayerhq.hu/MPlayer/releases/ \
@@ -101,6 +101,9 @@
 MAINTAINER=     riggs@rrr.de
 COMMENT=        High performance media player/encoder supporting many formats
 
+PATCH_SITES=    http://www.mplayerhq.hu/MPlayer/patches/
+PATCHFILES+=    asmrules_fix_20061231.diff
+
 LIB_DEPENDS=    png.5:${PORTSDIR}/graphics/png
 
 USE_BZIP2=      yes
@@ -165,6 +168,7 @@
 OPTIONS+=       XVID "Enable XVID video codec support" on
 OPTIONS+=       REALPLAYER "Enable real player plugin" off
 OPTIONS+=       LIVEMEDIA "Enable LIVE555 streaming support" off
+OPTIONS+=       SMB "Enable Samba input support" off
 OPTIONS+=       FRIBIDI "Enable FriBiDi support" off
 OPTIONS+=       LIRC "Enable lirc support" off
 OPTIONS+=       LIBCDIO "Enable libcdio support" off
@@ -469,6 +473,13 @@
 BUILD_DEPENDS+=         ${LOCALBASE}/live/liveMedia/libliveMedia.a:${PORTSDIR}/net/liveMedia
 .else
 CONFIGURE_ARGS+=        --disable-live
+.endif
+
+.if defined(WITH_SMB)
+CONFIGURE_ARGS+=        --enable-smb
+LIB_DEPENDS+=           smbclient.0:${PORTSDIR}/net/samba-libsmbclient
+.else
+CONFIGURE_ARGS+=        --disable-smb
 .endif
 
 .if !defined(WITHOUT_XVID)
diff -ruN /usr/ports/multimedia/mplayer/distinfo mplayer/distinfo
--- /usr/ports/multimedia/mplayer/distinfo       Tue Nov 21 08:16:41 2006
+++ mplayer/distinfo     Sun Jan  7 21:41:34 2007
@@ -1,3 +1,6 @@
 MD5 (MPlayer-1.0rc1.tar.bz2) = 18c05d88e22c3b815a43ca8d7152ccdc
 SHA256 (MPlayer-1.0rc1.tar.bz2) = 8dd9dd61a0fe56904f5b76ddedb99bd359abaaf486e0b83b45e3357fecc81063
 SIZE (MPlayer-1.0rc1.tar.bz2) = 8414213
+MD5 (asmrules_fix_20061231.diff) = f0b71c38b1207c1d604be091876ac051
+SHA256 (asmrules_fix_20061231.diff) = 3f71e6f4e07940d4d55084d0df12404371bc4e534a3a6b0756ca73e44ddbc3c4
+SIZE (asmrules_fix_20061231.diff) = 1450
diff -ruN /usr/ports/multimedia/mplayer/files/patch-libavcodec-h264.c mplayer/files/patch-libavcodec-h264.c
--- /usr/ports/multimedia/mplayer/files/patch-libavcodec-h264.c  Thu Jan  1 01:00:00 1970
+++ mplayer/files/patch-libavcodec-h264.c        Sun Jan  7 22:14:39 2007
@@ -0,0 +1,11 @@
+--- libavcodec/h264.c.orig      Thu Dec 21 14:57:54 2006
++++ libavcodec/h264.c   Thu Dec 21 15:00:14 2006
+@@ -6034,7 +6034,7 @@
+     return ctx + 4 * cat;
+ }
+ 
+-static const __attribute((used)) uint8_t last_coeff_flag_offset_8x8[63] = {
++const __attribute((used)) uint8_t last_coeff_flag_offset_8x8[63] = {
+     0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1,
+     2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2,
+     3, 3, 3, 3, 3, 3, 3, 3, 4, 4, 4, 4, 4, 4, 4, 4,




State Changed
From-To:open->closed
By:itetcu
When:Mon Jan 8 16:02:28 UTC 2007
Why:Committed. Thanks!

Reply via E-mail
From:dfilter@FreeBSD.ORG (dfilter service)
Date:Mon, 8 Jan 2007 16:02:32 +0000 (UTC)
itetcu 2007-01-08 16:02:14 UTC

FreeBSD ports repository

Modified files:
multimedia/mplayer Makefile distinfo
Added files:
multimedia/mplayer/files patch-libavcodec-h264.c
Log:
- fix build of mplayer with h264 and polyaudio, when an external reference was
generated to: last_coeff_flag_offset in the polyaudio module, that is static
in the h264.
- security fix provided by the mplayer development team for a possible remote
buffer overflow in rtsp streams
- Correct library dependence and OPTIONS for samba support

PR: ports/107217
Submitted by: Sergio Lenzi [1], Thomas E. Zander (maintainer) [2]
Approved by: maintainer
Security: http://www.vuxml.org/freebsd/b2ff68b2-9f29-11db-a4e4-0211d87675b7.hml

Revision Changes Path
1.151 +12 -1 ports/multimedia/mplayer/Makefile
1.35 +3 -0 ports/multimedia/mplayer/distinfo
1.1 +11 -0 ports/multimedia/mplayer/files/patch-libavcodec-h264.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"


Reply via E-mail
From:dfilter@FreeBSD.ORG (dfilter service)
Date:Mon, 8 Jan 2007 16:06:48 +0000 (UTC)
itetcu 2007-01-08 16:06:29 UTC

FreeBSD ports repository

Modified files:
security/vuxml vuln.xml
Log:
Add mplayer RealMedia RTSP streams buffer overflow entry.

PR: ports/107217
Submitted by: Thomas E. Zander (multimedia/mplayer maintainer)
Reviewed by: simon@

Revision Changes Path
1.1267 +41 -1 ports/security/vuxml/vuln.xml
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"


Unformatted:
 
Submit Followup | Raw PR | Find another PR