ports/163613: [PATCH] devel/libgtop: fix build on 10-CURRENT
| From: | Steve Wills <swills@freebsd.org> |
| Date: | Sun, 25 Dec 2011 15:07:45 -0500 (EST) |
| Subject: | [PATCH] devel/libgtop: fix build on 10-CURRENT |
| Send-pr version: | 3.113 |
| Number: | 163613 |
| Category: | ports |
| Synopsis: | [PATCH] devel/libgtop: fix build on 10-CURRENT |
| Severity: | non-critical |
| Priority: | low |
| Responsible: | gnome |
| State: | closed |
| Class: | change-request |
| Arrival-Date: | Sun Dec 25 20:10:13 UTC 2011 |
| Closed-Date: | Wed Dec 28 21:03:51 UTC 2011 |
| Last-Modified: | Wed Dec 28 21:10:10 UTC 2011 |
| Originator: | Steve Wills |
| Release: | FreeBSD 10.0-CURRENT amd64 |
| Organization |
| Environment |
| System: FreeBSD meatwad.mouf.net 10.0-CURRENT FreeBSD 10.0-CURRENT #8: Mon Dec 19 15:53:28 EST 2011 |
| Description |
| I experienced the same build failure with libgtop seen here: http://pointyhat.freebsd.org/errorlogs/i386-errorlogs/e.10.20111207031942/libgtop-2.28.3_2.log gmake[3]: Entering directory `/work/a/ports/devel/libgtop/work/libgtop-2.28.3/sysdeps/freebsd' ... gnome-libtool: compile: cc -DHAVE_CONFIG_H -I. -I../.. -I../.. -I../.. -I../../sysdeps/freebsd -I../../include -I/usr/local/include/glib-2.0 -I/usr/local/include -I/usr/local/include -DHAVE_NET_IF_VAR_H -Winline -Wall -std=gnu89 -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wsign-compare -O2 -pipe -fno-strict-aliasing -MT open.lo -MD -MP -MF .deps/open.Tpo -c open.c -fPIC -DPIC -o .libs/open.o open.c: In function 'glibtop_open_s': open.c:47: error: '__FreeBSD_kernel_version' undeclared (first use in this function) open.c:47: error: (Each undeclared identifier is reported only once open.c:47: error: for each function it appears in.) gmake[3]: *** [open.lo] Error 1 The attached patch fixes it for me. The patch is mainly noise due to the file files/patch-sysdeps_freebsd_open.c not being updated I think, but the main change is that the check for __FreeBSD_kernel__ and usage of __FreeBSD_kernel_version was removed in favor of just using __FreeBSD_version all the time. I believe this is the correct thing to do, but I'm not 100% sure. Port maintainer (gnome@FreeBSD.org) is cc'd. Generated with FreeBSD Port Tools 0.99 |
| How-To-Repeat |
| Fix |
| Download libgtop-2.28.3_2.patch |
Index: files/patch-sysdeps_freebsd_open.c |
| Release-Note |
| Audit-Trail |
| Responsible Changed | |
|---|---|
| From-To: | freebsd-ports-bugs->gnome |
| By: | edwin |
| When: | Sun Dec 25 20:10:28 UTC 2011 |
| Why: | Over to maintainer (via the GNATS Auto Assign Tool) |
| State Changed | |
|---|---|
| From-To: | open->closed |
| By: | marcus |
| When: | Wed Dec 28 21:03:39 UTC 2011 |
| Why: | Committed, thanks! |
| Reply via E-mail [Link] | |
|---|---|
| From: | dfilter@FreeBSD.ORG (dfilter service) |
| To: | bug-followup@FreeBSD.org |
| Date: | Wed, 28 Dec 2011 21:03:46 +0000 (UTC) |
| marcus 2011-12-28 21:03:37 UTC FreeBSD ports repository Modified files: devel/libgtop/files patch-sysdeps_freebsd_open.c Log: Fix the build on FreeBSD 10.X. PR: 163613 Submitted by: swills Revision Changes Path 1.2 +19 -19 ports/devel/libgtop/files/patch-sysdeps_freebsd_open.c _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org" | |
| Unformatted |
