Skip site navigation (1)Skip section navigation (2)

ports/134594: [PATCH] security/pwman3: use cElementTree and sqlite comes with Python 2.5

From:Li-Wen Hsu <lwhsu@FreeBSD.org>
Date:Sun, 17 May 2009 10:36:39 +0800 (CST)
Subject:[PATCH] security/pwman3: use cElementTree and sqlite comes with Python 2.5
Send-pr version:3.113

Number:134594
Category:ports
Synopsis:[PATCH] security/pwman3: use cElementTree and sqlite comes with Python 2.5
Severity:non-critical
Priority:low
Responsible:lwhsu@FreeBSD.org
State:feedback
Class:change-request
Arrival-Date:Sun May 17 03:00:08 UTC 2009
Closed-Date:
Last-Modified:Mon May 18 16:50:03 UTC 2009
Originator:Li-Wen Hsu
Release:FreeBSD 7.2-RELEASE amd64

Organization:
 
Environment:
System: FreeBSD FreeBSD.cs.nctu.edu.tw 7.2-RELEASE FreeBSD 7.2-RELEASE #0: Thu May 7 22:34:33 CST
 
Description:
Changing depends to cElementTree and sqlite comes with Python 2.5 .

Port maintainer (yarodin@gmail.com) is cc'd.

Generated with FreeBSD Port Tools 0.77
 
How-To-Repeat:
 
Fix:
Download pwman3-0.0.6_1.patch
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/security/pwman3/Makefile,v
retrieving revision 1.1
diff -u -u -r1.1 Makefile
--- Makefile     6 May 2008 03:09:35 -0000       1.1
+++ Makefile     17 May 2009 02:35:18 -0000
@@ -7,6 +7,7 @@
 PORTNAME=       pwman3
 PORTVERSION=    0.0.6
+PORTREVISION=   1
 CATEGORIES=     security python
 MASTER_SITES=   http://pwman.bleurgh.com/~ivan/pwman3/source/ \
                 http://source.antisupport.com/pwman3/
@@ -15,12 +16,17 @@
 MAINTAINER=     yarodin@gmail.com
 COMMENT=        Console password management application with sql storage
-RUN_DEPENDS=    ${PYTHON_PKGNAMEPREFIX}pycrypto>=2.0:${PORTSDIR}/security/py-pycrypto \
-                ${PYTHON_PKGNAMEPREFIX}cElementTree>=1.0.5:${PORTSDIR}/devel/py-celementtree \
-                ${PYTHON_PKGNAMEPREFIX}pysqlite>=2.0.5:${PORTSDIR}/databases/py-pysqlite23
+RUN_DEPENDS=    ${PYTHON_PKGNAMEPREFIX}pycrypto>=2.0:${PORTSDIR}/security/py-pycrypto
 USE_PYTHON=             2.5+
 USE_PYDISTUTILS=        yes
 PYDISTUTILS_PKGNAME=    Pwman3
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+post-patch:
+        ${REINPLACE_CMD} -e s,cElementTree,xml.etree.cElementTree, ${WRKSRC}/pwman/exchange/exporter.py
+        ${REINPLACE_CMD} -e s,cElementTree,xml.etree.cElementTree, ${WRKSRC}/pwman/exchange/importer.py
+        ${REINPLACE_CMD} -e s,pysqlite2,sqlite3, ${WRKSRC}/pwman/data/drivers/sqlite.py
+
+.include <bsd.port.post.mk>


Release-Note:
 
Audit-Trail:
Responsible Changed
From-To:freebsd-ports-bugs->lwhsu
By:edwin
When:Sun May 17 03:00:36 UTC 2009
Why:Submitter has GNATS access (via the GNATS Auto Assign Tool)

State Changed
From-To:open->feedback
By:edwin
When:Sun May 17 03:00:41 UTC 2009
Why:Awaiting maintainers feedback (via the GNATS Auto Assign Tool)

Reply via E-mail
From:Edwin Groothuis <edwin@FreeBSD.org>
Date:Sun, 17 May 2009 03:00:39 UT
Maintainer of security/pwman3,

Please note that PR ports/134594 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/134594

--
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org

Reply via E-mail
From:Yar Odin <yarodin@gmail.com>
Date:Sun, 17 May 2009 12:55:17 +0600

boundary="Boundary-01=_VT7DKDDBYJl0B1Z"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

--Boundary-01=_VT7DKDDBYJl0B1Z
Content-Type: text/plain;
charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Sunday 17 May 2009 09:00:39 Edwin Groothuis wrote:
> Maintainer of security/pwman3,
>
> Please note that PR ports/134594 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dports/134594

I got after build with this patch...

# pwman3
Error: python-sqlite not installed

Why do you think that's python2.5 comes sqlite and it enough?
=2D--------
Note that some of the standard modules are provided as separate
ports since they require extra dependencies:

bsddb databases/py-bsddb
gdbm databases/py-gdbm
sqlite3 databases/py-sqlite3
tkinter x11-toolkits/py-tkinter
=2D--------

Propper patch attached

P.S. 10x for aware me ;]
=2D-=20
Yar Odin <yarodin@gmail.com>
GnuPG Key: http://ipfw.ru/yarodin.asc
GnuPG Key ID: 0x3449D79E

--Boundary-01=_VT7DKDDBYJl0B1Z
Content-Type: text/x-diff;
charset="iso 8859-1";
name="pwman-3.0.6_1.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="pwman-3.0.6_1.patch"

=2D-- Makefile.orig 2008-05-06 07:09:35.000000000 +0400
+++ Makefile 2009-05-17 10:46:13.000000000 +0400
@@ -7,6 +7,7 @@
=20
PORTNAME=3D pwman3
PORTVERSION=3D 0.0.6
+PORTREVISION=3D 1
CATEGORIES=3D security python
MASTER_SITES=3D http://pwman.bleurgh.com/~ivan/pwman3/source/ \
http://source.antisupport.com/pwman3/
@@ -16,11 +17,17 @@
COMMENT=3D Console password management application with sql storage
=20
RUN_DEPENDS=3D ${PYTHON_PKGNAMEPREFIX}pycrypto>=3D2.0:${PORTSDIR}/security=
/py-pycrypto \
=2D ${PYTHON_PKGNAMEPREFIX}cElementTree>=3D1.0.5:${PORTSDIR}/devel/py-cele=
menttree \
=2D ${PYTHON_PKGNAMEPREFIX}pysqlite>=3D2.0.5:${PORTSDIR}/databases/py-pysq=
lite23
+ ${PYTHON_PKGNAMEPREFIX}sqlite3>=3D2.5:${PORTSDIR}/databases/py-sqlite3
=20
USE_PYTHON=3D 2.5+
USE_PYDISTUTILS=3D yes
PYDISTUTILS_PKGNAME=3D Pwman3
=20
=2D.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+post-patch:
+ ${REINPLACE_CMD} -e s,cElementTree,xml.etree.cElementTree, ${WRKSRC}/pwma=
n/exchange/exporter.py
+ ${REINPLACE_CMD} -e s,cElementTree,xml.etree.cElementTree, ${WRKSRC}/pwma=
n/exchange/importer.py
+ ${REINPLACE_CMD} -e s,pysqlite2,sqlite3, ${WRKSRC}/pwman/data/drivers/sql=
ite.py
+
+.include <bsd.port.post.mk>

--Boundary-01=_VT7DKDDBYJl0B1Z--



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)

iD8DBQBKD7TjOMLFRTRJ154RAnDVAJ9bXTSjt/TNLm1aU6w0BCw2v82eigCaA0A3
fJTCPmzp9P31idY07fXKVSs=
=8SJ5
-----END PGP SIGNATURE-----



Reply via E-mail
From:Li-Wen Hsu <lwhsu@FreeBSD.org>
Date:Tue, 19 May 2009 00:28:00 +0800
Previous mail seems lost. And sorry I attach the wrong patch,
could you check this one?

http://people.freebsd.org/~lwhsu/pwman3.diff

Thanks,
Li-Wen

--
Li-Wen Hsu <lwhsu AT FreeBSD.org>
http://lwhsu.org

Unformatted:
 
Submit Followup | Raw PR | Find another PR