Skip site navigation (1)Skip section navigation (2)

ports/125996: [patch] x11/nvidia-driver - remove pkg_info statements

From:Edwin Groothuis <edwin@mavetju.org>
Date:Sun, 27 Jul 2008 10:58:51 +1000 (EST)
Subject:[patch] x11/nvidia-drive - remove pkg_info statements
Send-pr version:3.113

Number:125996
Category:ports
Synopsis:[patch] x11/nvidia-driver - remove pkg_info statements
Severity:non-critical
Priority:low
Responsible:danfe@FreeBSD.org
State:feedback
Class:change-request
Arrival-Date:Sun Jul 27 01:00:13 UTC 2008
Closed-Date:
Last-Modified:Fri Dec 26 18:15:11 UTC 2008
Originator:Edwin Groothuis
Release:FreeBSD 7.0-RELEASE-p1 i386

Organization:
-
 
Environment:
System: FreeBSD k7.mavetju 7.0-RELEASE-p1 FreeBSD 7.0-RELEASE-p1 #2: Wed May 28 08:12:56 EST 2008 edwin@k7.mavetju:/usr/src/sys/i386/compile/k7 i386
Description:
 
How-To-Repeat:
 
Fix:
Cleanup of x11/nvidia-driver

Download patch-1.diff
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/x11/nvidia-driver/Makefile,v
retrieving revision 1.79
diff -u -r1.79 Makefile
--- Makefile     18 Jun 2008 19:46:18 -0000      1.79
+++ Makefile     27 Jul 2008 00:45:08 -0000
@@ -40,10 +40,8 @@
 .include <bsd.port.pre.mk>
-# XXX Should use ${PKG_INFO} XXX
-#
-XSERVVERSION!=  /usr/sbin/pkg_info -O x11-servers/XFree86-4-Server 2>/dev/null | ${GREP} Server- || /usr/sbin/pkg_info -O x11-servers/xorg-server 2>/dev/null | ${GREP} server- || /usr/sbin/pkg_info -qO x11-servers/xorg-server-snap 2>/dev/null || true
-XLIBVERSION!=   /usr/sbin/pkg_info -O x11/XFree86-4-libraries 2>/dev/null | ${GREP} libraries- || /usr/sbin/pkg_info -O graphics/libGL 2>/dev/null | ${GREP} libGL- || true
+XSERVVERSION!=  ${PKG_INFO} -O x11-servers/XFree86-4-Server 2>/dev/null | ${GREP} Server- || ${PKG_INFO} -O x11-servers/xorg-server 2>/dev/null | ${GREP} server- || ${PKG_INFO} -qO x11-servers/xorg-server-snap 2>/dev/null || true
+XLIBVERSION!=   ${PKG_INFO} -O x11/XFree86-4-libraries 2>/dev/null | ${GREP} libraries- || ${PKG_INFO} -O graphics/libGL 2>/dev/null | ${GREP} libGL- || true
 .if empty(XSERVVERSION)
 IGNORE=         needs an X server implementation installed


Release-Note:
 
Audit-Trail:
Responsible Changed
From-To:freebsd-ports-bugs->danfe
By:edwin
When:Sun Jul 27 01:01:58 UTC 2008
Why:Over to maintainer (via the GNATS Auto Assign Tool)

State Changed
From-To:open->feedback
By:danfe
When:Fri Dec 26 18:11:57 UTC 2008
Why:Last time I checked, it did not work. If you have relevant analysis
(or, better, provide reference to bpm revision where it was fixed) I'm
all ears. Thanks.

Unformatted:
 
Submit Followup | Raw PR | Find another PR