Skip site navigation (1)Skip section navigation (2)

CVS log for ports/archivers/cabextract/Makefile

[BACK] Up to [FreeBSD] / ports / archivers / cabextract

Request diff between arbitrary revisions

Keyword substitution: kv
Default branch: MAIN

Revision 1.21: download - view: text, markup, annotated - select for diffs
Sat Jun 11 21:04:59 2011 UTC (8 months ago) by gabor
Branches: MAIN
CVS tags: RELEASE_9_0_0, HEAD
Diff to: previous 1.20: preferred, colored
Changes since revision 1.20: +1 -1 lines
- Update to 1.4
Revision 1.20: download - view: text, markup, annotated - select for diffs
Thu Jul 29 22:45:51 2010 UTC (18 months, 1 week ago) by gabor
Branches: MAIN
CVS tags: RELEASE_8_2_0, RELEASE_7_4_0, RELEASE_6_EOL
Diff to: previous 1.19: preferred, colored
Changes since revision 1.19: +2 -1 lines
Update to 1.3, which fixes two security bugs. Detailed description
from the author follows.

Bug 1: Infinite loop in MS-ZIP decoder [1]

The MS-ZIP and Quantum decoders read bits in roughly the same way as the LZX
decoder, however they don't have "inject two fake bytes" code.

In the situation where read() provides zero bytes, e.g. at the end of file or
end of a CAB block, the LZX decoder handles this by injecting two fake bytes,
then returns an error on subsequent calls. MS-ZIP and Quantum instead return
zero bytes without error. However, all three decoders are written to presume
they will get at least one byte. So this could lead to an infinite loop in
MS-ZIP and Quantum. An infinite loop has definitely been seen in MS-ZIP -
there is a while loop in inflate() of an uncompressed block (block type 0)
which won't end until enough input is provided.

Partial solution: change "if (read < 0)" to "if (read <= 0)" in mszipd.c and
qtmd.c.
- http://libmspack.svn.sourceforge.net/viewvc/libmspack?view=revision&revision=90

However, this breaks compatibility with a number of MS-ZIP/Quantum encoded
files. A full solution would be to implement the same bit-reading system as
LZX. I've done this now, merging all the bit-reading and huffman-reading
code into two new files; readbits.h and readhuff.h
- http://libmspack.svn.sourceforge.net/viewvc/libmspack?view=revision&revision=95

There are several further changes made to integrate readbits.h and readhuff.h,
I recommend you look at the latest version in the source repository.
- http://libmspack.svn.sourceforge.net/viewvc/libmspack/libmspack/trunk/mspack/

Bug 2: Segmentation fault in "cabextract -t"

This bug may not affect you, depending on your implementation of
mspack_system->write(). It does cause a segfault in cabextract's
cabx_write() in "-t" (test archive) mode.

In the Quantum decoder, when the window wrap is reached, all currently
unwritten data is flushed to disk. Sometimes, less data is needed than
is flushed, which makes the variable out_bytes negative.

When the main decoding loop finishes, a final call to write() is made if
out_bytes is not zero. In that situation, it calls mspack_system->write() with
a negative byte count, e.g. -129 bytes. You should reject this. In
cabextract's "-t" mode, this is not caught, but instead converted to an
unsigned integer and passed to md5_process_bytes(), which tries to
read e.g. 4294967167 bytes, causing it to read beyond the end of
valid process space and thus segfault.

Solution:
- Break out to the end of the decoding loop immediately if the flush would be more than needed.
   http://libmspack.svn.sourceforge.net/viewvc/libmspack/libmspack/trunk/mspack/qtmd.c?r1=114&r2=113
- Add checking of the "bytes" argument in mspack_system read() / write() implementations, just to be sure.
   http://libmspack.svn.sourceforge.net/viewvc/libmspack?view=revision&revision=118

Security:	SA40719 [1]
Revision 1.19: download - view: text, markup, annotated - select for diffs
Thu Mar 20 09:19:32 2008 UTC (3 years, 10 months ago) by pav
Branches: MAIN
CVS tags: RELEASE_8_1_0, RELEASE_8_0_0, RELEASE_7_3_0, RELEASE_7_2_0, RELEASE_7_1_0, RELEASE_6_4_0, RELEASE_5_EOL
Diff to: previous 1.18: preferred, colored
Changes since revision 1.18: +0 -1 lines
- Remove USE_GETOPT_LONG which is a no-op since March 2007
Revision 1.18: download - view: text, markup, annotated - select for diffs
Tue Aug 7 18:21:25 2007 UTC (4 years, 6 months ago) by sobomax
Branches: MAIN
CVS tags: RELEASE_7_0_0, RELEASE_6_3_0
Diff to: previous 1.17: preferred, colored
Changes since revision 1.17: +1 -1 lines
Update MASTER_SITE and description to point to the new home page.

Submitted by:	Stuart Caie (author)
Revision 1.17: download - view: text, markup, annotated - select for diffs
Tue Jan 2 21:12:04 2007 UTC (5 years, 1 month ago) by gabor
Branches: MAIN
CVS tags: RELEASE_4_EOL, PRE_XORG_7
Diff to: previous 1.16: preferred, colored
Changes since revision 1.16: +14 -10 lines
- Update to 1.2
- Remove unnecessary patch
- Style

Approved by:	erwin (mentor)
Revision 1.16: download - view: text, markup, annotated - select for diffs
Fri Dec 8 13:46:25 2006 UTC (5 years, 2 months ago) by gabor
Branches: MAIN
Diff to: previous 1.15: preferred, colored
Changes since revision 1.15: +1 -1 lines
Change my e-mail address.

Approved by:	erwin (mentor)
Revision 1.15: download - view: text, markup, annotated - select for diffs
Sun Sep 10 17:53:55 2006 UTC (5 years, 5 months ago) by erwin
Branches: MAIN
CVS tags: RELEASE_6_2_0
Diff to: previous 1.14: preferred, colored
Changes since revision 1.14: +8 -4 lines
- Don't override CONFIGURE_TARGET, it compiles without that
- Add some more PORTDOCS
- Respect MAN1PREFIX
- Bump PORTREVISION
- Take maintainership

PR:		103103
Submitted by:	Gabor Kovesdan <gabor@FreeBSD.org>
Revision 1.14: download - view: text, markup, annotated - select for diffs
Tue Apr 12 03:24:46 2005 UTC (6 years, 10 months ago) by obrien
Branches: MAIN
CVS tags: RELEASE_6_1_0, RELEASE_6_0_0, RELEASE_5_5_0
Diff to: previous 1.13: preferred, colored
Changes since revision 1.13: +1 -1 lines
At Kris's request, back out the MACHINE_ARCH spelling correction until
after 5.4-RELEASE.
Revision 1.13: download - view: text, markup, annotated - select for diffs
Mon Apr 11 08:01:16 2005 UTC (6 years, 10 months ago) by obrien
Branches: MAIN
Diff to: previous 1.12: preferred, colored
Changes since revision 1.12: +1 -1 lines
Assist getting more ports working on AMD64 by obeying the
Ports Collection documentation and use 'ARCH' rather than 'MACHINE_ARCH'.
Revision 1.12: download - view: text, markup, annotated - select for diffs
Sat Oct 23 08:35:51 2004 UTC (7 years, 3 months ago) by okazaki
Branches: MAIN
CVS tags: RELEASE_5_4_0, RELEASE_4_11_0
Diff to: previous 1.11: preferred, colored
Changes since revision 1.11: +1 -1 lines
Update to version 1.1.

PR:		72817
Submitted by:	KATO Tsuguru
Revision 1.11: download - view: text, markup, annotated - select for diffs
Tue Mar 16 13:14:57 2004 UTC (7 years, 10 months ago) by krion
Branches: MAIN
CVS tags: RELEASE_5_3_0, RELEASE_4_10_0
Diff to: previous 1.10: preferred, colored
Changes since revision 1.10: +16 -4 lines
- Update to version 1.0

PR:		ports/64328
Submitted by:	Ports Fury
Revision 1.10: download - view: text, markup, annotated - select for diffs
Thu Feb 5 20:36:51 2004 UTC (8 years ago) by trevor
Branches: MAIN
Diff to: previous 1.9: preferred, colored
Changes since revision 1.9: +1 -0 lines
Use PLIST_FILES.

Reviewed by:	marcus
Revision 1.9: download - view: text, markup, annotated - select for diffs
Tue Jul 29 09:12:21 2003 UTC (8 years, 6 months ago) by sobomax
Branches: MAIN
CVS tags: RELEASE_5_2_1, RELEASE_5_2_0, RELEASE_4_9_0
Diff to: previous 1.8: preferred, colored
Changes since revision 1.8: +1 -1 lines
Let be hohest: I really don't have a time now to properly maintain all
these great pieces of software, so that let others with more free time
to take over them.
Revision 1.8: download - view: text, markup, annotated - select for diffs
Mon Jul 14 02:52:54 2003 UTC (8 years, 7 months ago) by sf
Branches: MAIN
Diff to: previous 1.7: preferred, colored
Changes since revision 1.7: +2 -4 lines
get rid of libgnugetopt dependency for -CURRENT,
use USE_GETOPT_LONG instead.
Revision 1.7: download - view: text, markup, annotated - select for diffs
Fri Mar 7 05:55:10 2003 UTC (8 years, 11 months ago) by ade
Branches: MAIN
CVS tags: RELEASE_5_1_0, RELEASE_4_8_0
Diff to: previous 1.6: preferred, colored
Changes since revision 1.6: +1 -0 lines
Clear moonlight beckons.
Requiem mors pacem pkg-comment,
And be calm ports tree.

E Nomini Patri, E Fili, E Spiritu Sancti.
Revision 1.6: download - view: text, markup, annotated - select for diffs
Fri Aug 30 12:08:16 2002 UTC (9 years, 5 months ago) by sobomax
Branches: MAIN
CVS tags: RELEASE_5_0_0, RELEASE_4_7_0
Diff to: previous 1.5: preferred, colored
Changes since revision 1.5: +3 -3 lines
Update to 0.6.

PR:		41729
Submitted by:	Ports Fury
Revision 1.5: download - view: text, markup, annotated - select for diffs
Mon Aug 27 08:35:40 2001 UTC (10 years, 5 months ago) by sobomax
Branches: MAIN
CVS tags: RELEASE_5_0_DP1, RELEASE_4_6_2, RELEASE_4_6_1, RELEASE_4_6_0, RELEASE_4_5_0, RELEASE_4_4_0
Diff to: previous 1.4: preferred, colored
Changes since revision 1.4: +1 -1 lines
Update to 0.5.

Submitted by:	petef
Revision 1.4: download - view: text, markup, annotated - select for diffs
Mon Aug 20 08:13:32 2001 UTC (10 years, 5 months ago) by sobomax
Branches: MAIN
Diff to: previous 1.3: preferred, colored
Changes since revision 1.3: +1 -1 lines
Update to 0.4.
Revision 1.3: download - view: text, markup, annotated - select for diffs
Tue Aug 7 11:57:53 2001 UTC (10 years, 6 months ago) by sobomax
Branches: MAIN
Diff to: previous 1.2: preferred, colored
Changes since revision 1.2: +5 -1 lines
Update to 0.3.
Revision 1.2: download - view: text, markup, annotated - select for diffs
Tue Mar 6 13:29:20 2001 UTC (10 years, 11 months ago) by sobomax
Branches: MAIN
CVS tags: RELEASE_4_3_0
Diff to: previous 1.1: preferred, colored
Changes since revision 1.1: +3 -15 lines
Update to 0.2.
Revision 1.1: download - view: text, markup, annotated - select for diffs
Thu Nov 30 14:21:28 2000 UTC (11 years, 2 months ago) by sobomax
Branches: MAIN
Add cabextract - a program to extract Microsoft cabinet (.CAB) files.
Diff request

This form allows you to request diffs between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.

Log view options